AlloSphere-Research-Group / allolib

Library for interactive multimedia application development
BSD 3-Clause "New" or "Revised" License
36 stars 14 forks source link

instance_drawing.cpp improvements #19

Closed kybr closed 5 years ago

kybr commented 5 years ago

I'm talking about this example:

examples/graphics/instance_drawing.cpp

Float4 is just a Vec4f, so use a Vec4f. Except the fourth element is always 1, so use Vec3f instead, unless this operation is much more efficent than vec4 p = vec4(scale * position + offset, 1.0); where offset is a vec3.

This example does not offer any context beyond the name of the file. Please list a goal (or a description), a set of topics/tags/keywords, an author, and a date. Like this.

younkhg commented 5 years ago

Using Float4 was to show that any user data struct can be used. I'll add comment about it. Changing to vec3 seems correct.

pushed f654d2202f8fed8ed225fe135e3d1e94da111613

mantaraya36 commented 5 years ago

I believe the issue has been solved by f654d22