Explicitly declare signed char for sTriTable (al_Isosurface.cpp)

AlloSphere-Research-Group / allolib

Library for interactive multimedia application development

BSD 3-Clause "New" or "Revised" License

36 stars 14 forks source link

Explicitly declare signed char for sTriTable (al_Isosurface.cpp) #51

Closed wang-edward closed 2 years ago

wang-edward commented 2 years ago

char is unsigned by default on some systems (tested Raspbian & Radxa Zero Debian). Throws allolib/src/graphics/al_Isosurface.cpp:322:68: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]

ghost commented 2 years ago

👇 Click on the image for a new way to code review

- Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=51&src=https%3A%2F%2Fgithub.com%2FAlloSphere-Research-Group%2Fallolib)

Legend

CodeSee Map Legend

mantaraya36 commented 2 years ago

Thanks! I'm curious to know how you are using allolib on RPi.