search

AlloSphere-Research-Group / allolib_playground

Code playground for allolib
13 stars 12 forks source link

pc - remove line from init.sh that deletes init.sh after running #10

Closed pconrad closed 1 year ago

pconrad commented 1 year ago

This PR removes the line rm init.sh from the end of init.sh.

It doesn't make sense to get rid of this file after running once, since the operations in this file need to be done each time you change from one commit of allolib_playground to another (e.g. when doing 'git bisect' to troubleshoot a problem.)

In addition, it creates a 'change' that has to be 'undone' if you are committing something to GitHub. This is confusing for novices, which is at odds with the stated goal of allolib_playground, i.e. to be a place where beginners can get started with as little confusion as possible.

konhyong commented 1 year ago

Thanks for the input.

The rm init.sh was an old line carried over from other templates where it was converting the repo into a new different repo.

Merged and closed.