Centralize thumbnail viewing

[EricClaeys]

• Replace the videos/index.php, keograms/index.php, and startrails/index.php with show_thumbnails.php.
• Improve the look of the thumbnails pages slightly.

[thomasjacquin]

@EricClaeys Does this fix issue #107 ?

Another issue I noticed is that the thumbnail generation stops if it encounters a file with size 0 or if the image is very narrow around summer time (1 px wide).

Also, I think we need to make sure the code is not favouring people hosting the website locally on their RPi over people who host it on a web host. For example, web hosts don't always have a lot of image and video editing programs installed. In my case, ffmpeg isn't installed. Maybe the RPi detection code would be useful here.

[EricClaeys]

@thomasjacquin Thomas, I'll have to check the code. It should complain about a 0-length file, then go to the next one. For the 1-column file, is that a keogram? Was your screenshot above from your Pi or a remote server?

I think we have remote servers covered. We check for the ability to run "exec()" for the ffmpeg command, since many remote servers either don't have ffmpeg or "exec()" is disabled. And we check that the PHP function to create thumbnails from .jpg/.png files is enabled. Did you find something else on a remote server that didn't work?

One of my "to do" items is to add an option to create the thumbnails on the Pi and upload to the remote server.

[thomasjacquin]

@EricClaeys The screenshot is from my remote server. exec() works, yet ffmpeg is not installed. The creation of jpg/png thumbnails is functional.

Regarding issue #107, I noticed that the directory is called keograms but the individual image prefix is keogram which breaks the thumbnail naming.

Yes, the 1px wide image is a keogram. It happens every year around summer solstice at my location.

[EricClaeys]

@thomasjacquin This PR fixes the issue with "keogram" versus "keograms" and the data not showing correctly.

I'd like to fix the problem with ffmpeg not being installed in a separate PR if that's ok with you, once this PR is merged. If it is, is this PR ready for approval?

Not sure what to do with a 1-pixel wide image. Can you post it so I can test?

[thomasjacquin]

@EricClaeys I agree, let's handle the ffmpeg issue in a different PR.

Here's an image that's 1px wide. https://www.thomasjacquin.com/allsky/keograms/keogram-20210626.jpg

[Pedritoprint]

@EricClaeys you remember my Problem one month ago? i have the same, because my WebServer don't understand the ffmpeg-command. "ffmpeg" is installed and now with the same version like RP has installed, but i think, the ffmpeg-configuration is different ant till today, i can't find a solution to make it running on my synology-NAS-Webserver and i'm still working on it.

[EricClaeys]

@Pedritoprint Try the attached file. Rename your current functions.php file to functions.php-ORIGINAL then install this file, removing the trailing .txt. It won't solve your problem but may give a better idea of what's happening. Press F12 in the browser, then click on >> then Console. This file should produce some message.

functions.php.txt

[Pedritoprint]

This is the output in console. I think there is a newer WEB-SW on github? greetings Peter btw, i saw e text-line under the startpage of my allsky-web with following text: 50) { // The initial analyticsTracking.js file has a comment line "//Include your Google Analytics code here" which is < 50 characters. ?>

[EricClaeys]

@Pedritoprint. Peter, I suggest installing the newest code. It looks like there are some new and some old files. After you do that, then try the functions.php.txt file I posted.

[Pedritoprint]

here the new one with latest Web-SW.

[EricClaeys]

@Pedritoprint. What happens when you go to the timelapse video link? Does it create the thumbnails or produce a Console message?

[Pedritoprint]

This is the result after press timelaps video link. No thumbnails generated, but link to videos ar working.

[Pedritoprint]

Now i copied the missing "NoThumbnail.png" to the video folder and then it looks better.

this with your test file.