search

AllskyTeam / allsky

A Raspberry Pi operated Wireless Allsky Camera
MIT License
1.13k stars 177 forks source link

added rsync to list of upload protocols #3581

Closed MichelMoriniaux closed 3 months ago

MichelMoriniaux commented 3 months ago

was having a lot of issues with scp slowness to upload from my remote observatory to the other side of the world. rsync solved all my problems.

updated uploads.sh and config files to 2024 branch

MichelMoriniaux commented 3 months ago

was not able to test this as my skycam is in 'prod' and I don't have a spare one.

please check if the changes in options.json.repo valuedependson keys are correct, as I was not sure how these are used

Also in upload.sh I did the same implem as previously with a separate section, maybe merging with scp as you suggested could be a possibility but I preferred to play it safe with something that I have actually running on mine. To clarify a question you had with the _REMOTE_PORT="-p ${REMOTEPORT}" -p flag does not apply to rsync but to the ssh command called by the -e flag ( you don't need -e 'ssh ...' to set -i or -p if you have a properly configured ~/.ssh/config but I'm not sure you can expect users to configure theirs right)

EricClaeys commented 3 months ago

@MichelMoriniaux Michel, Thanks a bunch. I now understand why you used "-p PORT". valuedependson isn't used - it's basically a reminder how to implement the "depends" feature in the next release where some settings won't appear depending on the value of other settings. I made a couple minor changes to be consistent with our style, and merged the scp and rsync code in upload.sh

If you follow the instructions for upgrading allsky (using allsky-OLD) you can easily install the new release and test it, then run ./install.sh --restore to restore to your current version.

Thanks again.

EricClaeys commented 3 months ago

Forgot to say, after renaming "allsky" to "allsky-OLD" you get the new release via git --branch v2024.xx.xx ...