AllskyTeam / allsky

A Raspberry Pi operated Wireless Allsky Camera
MIT License
1.19k stars 180 forks source link

Timelapse uploading to wrong directory #552

Closed maserowik closed 3 years ago

maserowik commented 3 years ago

I did a fresh git pull today and redid my custom settings. I did a endOfNight.sh from a ssh session and it appears the my timelapse is going to a different location compared to the keograms and startrails.

< endOfNight.sh: ===== Generating Keogram upload.sh: FTP'ing /home/pi/allsky/images/20211003/keogram/keogram-20211003.jpg to /domains/n3bsq.com/public_html/allsky/keograms//keogram-20211003.jpg INFO: '/home/pi/allsky/tmp/lftp_cmds.txt' contains the lftp commands used to upload the file.

endOfNight.sh: ===== Generating Startrails Minimum: 0.288899 maximum: 0.999769 mean: 0.814339 median: 0.963642 No images below threshold, writing the minimum image only upload.sh: FTP'ing /home/pi/allsky/images/20211003/startrails/startrails-20211003.jpg to /domains/n3bsq.com/public_html/allsky/startrails//startrails-20211003.jpg INFO: '/home/pi/allsky/tmp/lftp_cmds.txt' contains the lftp commands used to upload the file.

endOfNight.sh: ===== Generating Timelapse timelapse.sh: Processing 23 images... [swscaler @ 0x22e7e70] deprecated pixel format used, make sure you did set range correctly timelapse.sh: Timelapse was created upload.sh: FTP'ing /home/pi/allsky/images/20211003/allsky-20211003.mp4 to allsky-20211003.mp4 INFO: '/home/pi/allsky/tmp/lftp_cmds.txt' contains the lftp commands used to upload the file. pi@Pi-AllSky:~/allsky/scripts $

for the timelapse it is not appending the /domains/n3bsq.com/public_html/allsky/videos/filename

my ftp settings are as follows

IMGDIR='/domains/n3bsq.com/public_html/allsky/image/' MP4DIR='/domains/n3bsq.com/public_html/allsky/videos/' KEOGRAM_DIR='/domains/n3bsq.com/public_html/allsky/keograms/' STARTRAILS_DIR='/domains/n3bsq.com/public_html/allsky/startrails/'

Mike

linuxkidd commented 3 years ago

Somewhere along the way... the upload scripts started using a variable name ( VIDEOS_DIR ) that don't exist in the ftp-settings (or any other) file. I'm guessing a locally used / future version got committed by accident.

To get your code working, you can modify the ftp-settings.sh file and change MP4DIR to VIDEOS_DIR.

I'll submit a PR for this shortly.