AllureOfTheStars / Allure

Allure of the Stars is a near-future Sci-Fi roguelike and tactical squad combat game written in Haskell; please offer feedback, e.g., after trying out the web frontend version at
http://allureofthestars.com
GNU Affero General Public License v3.0
213 stars 16 forks source link

Adds octopus animal #85

Closed tillydray closed 5 years ago

tillydray commented 6 years ago

Let me know if there's anything I should change. Addresses https://github.com/AllureOfTheStars/Allure/issues/84

Mikolaj commented 6 years ago

Wow, well done! Thank you. Let me nitpick directly in the code.

BTW, appveyor CI run of your PR will fail --- something broke there yesterday; perhaps they just made the machines slower and I go over the limit. Don't bother.

Mikolaj commented 6 years ago

First wild brainstorm idea: perhaps whenever octopus attacks with a jet of water, it should be pushed in the opposite direction than the attack (more or less, that would be implemented with the Pull effect that moves the actor in the opposite direction than his last move, so often it would match). That would capture both the attack and the speedy fleeing behaviour in one package.

Mikolaj commented 5 years ago

BTW, the Allure on Windows crash is now resolved (was text locale mismatch).

Mikolaj commented 5 years ago

While you are finish this up (no hurry, it's meant to be fun and the release is still far away :), I've added a mechanism that spawns aquatic actors peferably in water and aquatic animals on some water-rich levels, so you may want ot add ("aquatic", 90), ("aquatic animal", 90) to the ifreq field.

Mikolaj commented 5 years ago

@JasonMFry: I'd like to test actor generation, in particular in water and on water-rich levels for the upcoming release, so if you do not mind, I'd merge-rebase this PR and we can open an issue about the ink sac organ. Github is not particularly well suited to long-running PRs anyway, so we can focus on the technicalities of the new organ in a new PR.

Mikolaj commented 5 years ago

@JasonMFry: thanks a lot! Future work moved to #91.