search

AllureOfTheStars / Allure

Allure of the Stars is a near-future Sci-Fi roguelike and tactical squad combat game written in Haskell; please offer feedback, e.g., after trying out the web frontend version at
http://allureofthestars.com
GNU Affero General Public License v3.0
211 stars 16 forks source link

Updates cave descriptions #88

Closed Peritract closed 5 years ago

Peritract commented 5 years ago

Adds descriptions to some of the caves in accordance with #77.

I've tried to stay on message in line with the blurb, but I've probably dropped the ball somewhere.

Mikolaj commented 5 years ago

Hah, I totally forgot to mention in the file that all cave definitions up to and including shallowRogue are spaceship decks and the remainder up to ambush are single-level scenarios taking place on the surface of Triton, the Nepute's moon. That's a case of things are completely obvious to me that others have absolutely no chance of knowing. :) I should have separated them with -- * section header comments.

Let me know when the PR is ready for review (I only looked at the first description, which made me divulge the hidden facts :) ).

Other blurbs about the ship, etc. are in the descriptions here:

https://github.com/AllureOfTheStars/Allure/blob/5c0ff182def02055139cef8e40aab1475e9cda77/GameDefinition/Content/ItemKind.hs#L1757

https://github.com/AllureOfTheStars/Allure/blob/5c0ff182def02055139cef8e40aab1475e9cda77/GameDefinition/Content/ItemKindEmbed.hs#L363

https://github.com/AllureOfTheStars/Allure/blob/5c0ff182def02055139cef8e40aab1475e9cda77/GameDefinition/Content/ModeKind.hs

Peritract commented 5 years ago

Take a look now, let me know where I'm off the mark.

Mikolaj commented 5 years ago

Your descriptions are superb. I've run out of adjectives and expletives. You manage to notice/infer/invent and highlight the most poignant details of a scene. And you do this in so few words that I'd be still in the middle of an opening sentence. And I've been trained in condensing prose, for technical writing. :)

Mikolaj commented 5 years ago

I'm completely happy with this PR. Please merge/rebase whenever you are.

Peritract commented 5 years ago

I'm happy with it as stands, but I don't have the access to merge it in. Or did you mean something else?

Mikolaj commented 5 years ago

Oh, I see, you don't have the github repo access rights. I swear I invited you in the past. Anyway, I hope it works now, if you accept the invitation.

Mikolaj commented 5 years ago

BTW, if you could try the green arrow down and pick "Rebase and Merge" that would lead to simpler git history than just merging.

Mikolaj commented 5 years ago

:1st_place_medal:

Peritract commented 5 years ago

Thank you for the invite - I am very honoured.

As an aside, do you mind if I update my credit here and on LambdaHack? I'm moving away from anonymity now.

Mikolaj commented 5 years ago

Oh, yes, please do. I will be honoured in turn. :)