[SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion

[newnius]

Replace

    return retryRPC(new RpcCallable<Long>() {
      public Long call() {
        return mVersionService.getServiceVersion(
            GetServiceVersionPRequest.newBuilder().setServiceType(getRemoteServiceType()).build())
            .getVersion();
      }
    });

with

    return retryRPC(() -> mVersionService.getServiceVersion(
        GetServiceVersionPRequest.newBuilder().setServiceType(getRemoteServiceType()).build())
        .getVersion());

[Oscilloputer0627]

Yes, that's what we have discussed days ago. There seems sonething wrong with Java compliler or thedebug tool. I have no idea what is going wrong and how to solve it. man_shrugging

I will mark this task as resolved. You can try to find the solution if you are instered in this.

what about my score?

[Oscilloputer0627]

I hope I could get a 10/10, since I have been dealing with maven.

[Oscilloputer0627]

Thanks for your co-operation, it has been an honor to serve for Alluxio : )

[Oscilloputer0627]

But still, the dark and evil side of maven is not making me comfortabe. I'll say Makefile is sill the best and robust build tool, it runs everywhere, as soon as there is a computer.

[Oscilloputer0627]

Yes, that's what we have discussed days ago. There seems sonething wrong with Java compliler or thedebug tool. I have no idea what is going wrong and how to solve it. man_shrugging

I will mark this task as resolved. You can try to find the solution if you are instered in this.

https://github.com/Alluxio/alluxio/pull/9402 I hope I got scored, Thank you

[newnius]

what about my score?

According to the rules, it is 5.

[Oscilloputer0627]

what rules? can you at least give me 7? I need to pass this course

---

Best Wishes Orkesh Nurbolat

--------------原始邮件-------------- 发件人："Newnius "notifications@github.com; 发送时间：2019年7月3日(星期三) 上午9:26 收件人："Alluxio/new-contributor-tasks" new-contributor-tasks@noreply.github.com; 抄送："Oscilloputer0627 "151220121@smail.nju.edu.cn;"Comment "comment@noreply.github.com; 主题：Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

what about my score?

According to the rules, it is 5.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Oscilloputer0627]

I had put time into it and finally solve the shit you leave me. so please... I porved I am worthy.

---

Best Wishes Orkesh Nurbolat

--------------原始邮件-------------- 发件人："Newnius "notifications@github.com; 发送时间：2019年7月3日(星期三) 上午9:26 收件人："Alluxio/new-contributor-tasks" new-contributor-tasks@noreply.github.com; 抄送："Oscilloputer0627 "151220121@smail.nju.edu.cn;"Comment "comment@noreply.github.com; 主题：Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

what about my score?

According to the rules, it is 5.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Oscilloputer0627]

the reason it takes this long is mainly your fault bro. you first pick up a rock you can't put down, and that is why it take so long.

---

Best Wishes Orkesh Nurbolat

--------------原始邮件-------------- 发件人："Newnius "notifications@github.com; 发送时间：2019年7月3日(星期三) 上午9:26 收件人："Alluxio/new-contributor-tasks" new-contributor-tasks@noreply.github.com; 抄送："Oscilloputer0627 "151220121@smail.nju.edu.cn;"Comment "comment@noreply.github.com; 主题：Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

what about my score?

According to the rules, it is 5.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[newnius]

满分10分； 在ddl之前完成merge，10分； 在ddl之前提交pr，在ddl之后被merge，8分； 在ddl之后提交pr并被merge，5分； 没有被merge，0分。

[Oscilloputer0627]

please I need your score.

---

Best Wishes Orkesh Nurbolat

--------------原始邮件-------------- 发件人："Newnius "notifications@github.com; 发送时间：2019年7月3日(星期三) 上午9:35 收件人："Alluxio/new-contributor-tasks" new-contributor-tasks@noreply.github.com; 抄送："Oscilloputer0627 "151220121@smail.nju.edu.cn;"Comment "comment@noreply.github.com; 主题：Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

满分10分； 在ddl之前完成merge，10分； 在ddl之前提交pr，在ddl之后被merge，8分； 在ddl之后提交pr并被merge，5分； 没有被merge，0分。

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[newnius]

Rule is rule. But we will try to let you pass.

[Oscilloputer0627]

please, I am happy with 7, thank you.

---

Best Wishes Orkesh Nurbolat

--------------原始邮件-------------- 发件人："Newnius "notifications@github.com; 发送时间：2019年7月3日(星期三) 上午9:35 收件人："Alluxio/new-contributor-tasks" new-contributor-tasks@noreply.github.com; 抄送："Oscilloputer0627 "151220121@smail.nju.edu.cn;"Comment "comment@noreply.github.com; 主题：Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

满分10分； 在ddl之前完成merge，10分； 在ddl之前提交pr，在ddl之后被merge，8分； 在ddl之后提交pr并被merge，5分； 没有被merge，0分。

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Oscilloputer0627]

what else am I gonna lose??

------------------ Original ------------------ From: "Newnius"notifications@github.com; Date: Wed, Jul 3, 2019 09:37 AM To: "Alluxio/new-contributor-tasks"new-contributor-tasks@noreply.github.com; Cc: "Oscilloputer0627"151220121@smail.nju.edu.cn; "Comment"comment@noreply.github.com; Subject: Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

Rule is rule. But we will try to let you pass.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[newnius]

That's all you should do

[Oscilloputer0627]

If you say so.

------------------ Original ------------------ From: "Newnius"notifications@github.com; Date: Wed, Jul 3, 2019 09:41 AM To: "Alluxio/new-contributor-tasks"new-contributor-tasks@noreply.github.com; Cc: "Oscilloputer0627"151220121@smail.nju.edu.cn; "Comment"comment@noreply.github.com; Subject: Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

That's all you should do

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Oscilloputer0627]

Thanks again, for teaching me about this "maven", I really found it floods in "[Info]" but not too so obivious about errors. Lets use Makefile next time.

------------------ Original ------------------ From: "Newnius"notifications@github.com; Date: Wed, Jul 3, 2019 09:41 AM To: "Alluxio/new-contributor-tasks"new-contributor-tasks@noreply.github.com; Cc: "Oscilloputer0627"151220121@smail.nju.edu.cn; "Comment"comment@noreply.github.com; Subject: Re: [Alluxio/new-contributor-tasks] [SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio/core/common/src/main/java/alluxio/AbstractClient.java#getRemoteServiceVersion (#416)

That's all you should do

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.