Alluxio / Community

New Contributor Tasks for Alluxio
20 stars 38 forks source link

[SMALLFIX] Use static imports for standard test utilities in /alluxio/core/common/src/test/java/alluxio/util/executor/ControllableSchedulerTest.java #552

Closed newnius closed 4 years ago

newnius commented 5 years ago

Change

import org.junit.Assert;

to

import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

AND

Update all

Assert.{{ method }}*

to

{{ method }}*

For example

update

    Assert.assertTrue(mGraph.getRoots().isEmpty());

to

    assertTrue(mGraph.getRoots().isEmpty());
newnius commented 5 years ago

Put the static imports before non-static imports.

zhangfy commented 4 years ago

I want to get this task, but I find the latest version has already fixed. What can I do for this task?

newnius commented 4 years ago

You can choose another task or find one on Alluxio JIRA

Also, you can review the project to see what can be improved.

On GitHub, you cannot assign a issue if you are not the matainer.

zhangfy commented 4 years ago

@newnius Thank you, I'll look at the jira. As a newer, I looked at the Contribution Guide, maybe the doc should be modify.

zhangfy commented 4 years ago

@newnius By the way,how to be the maintaner? Do you have the detail steps? Thank you again!