Alluxio / Community

New Contributor Tasks for Alluxio
20 stars 38 forks source link

[SMALLFIX] Use static imports for standard test utilities in /alluxio/core/common/src/test/java/alluxio/wire/BlockLocationTest.java #560

Closed newnius closed 4 years ago

newnius commented 5 years ago

Change

import org.junit.Assert;

to

import static org.junit.Assert.assertEquals;

AND

Update all

Assert.{{ method }}*

to

{{ method }}*

For example

update

    Assert.assertTrue(mGraph.getRoots().isEmpty());

to

    assertTrue(mGraph.getRoots().isEmpty());
newnius commented 5 years ago

Put the static imports before non-static imports.

whyliyu commented 5 years ago

@newnius How can I take this task as my NEW CONTRIBUTOR TASK; I can't find "the link Assign to yourself " as the doc described :

"Browse any of the open New Contributor Alluxio Tasks and find one that is unassigned. You can press the link Assign to yourself in order to assign the task to yourself. "

LuQQiu commented 5 years ago

@whyliyu Please check the repo to see if the task is already fixed. If not, just use /assign @yourName to dynamically assign the issue to yourself. We will come up with better ways to deal with assignment later. Thanks for reporting the issue when running new contributor task.

luozhenglin commented 4 years ago

image i can't find " Assign to yourself"

maobaolong commented 4 years ago

/assign @whyliyu

maobaolong commented 4 years ago

@LuQQiu It is not work for /assign instrument

zhangfy commented 4 years ago

I want to get this task, but I find the latest version has already fixed. What can I do for this task?

zhangfy commented 4 years ago

And I also not fount how to assign to myself...