Alluxio / alluxio

Alluxio, data orchestration for analytics and machine learning in the cloud
https://www.alluxio.io
Apache License 2.0
6.87k stars 2.94k forks source link

Fix metrics when cache miss #18698

Open jja725 opened 1 month ago

jja725 commented 1 month ago

What changes are proposed in this pull request?

Fix metrics when there's cache miss

Why are the changes needed?

The correct behavior should be

  1. When read from external storage (or a cache miss?), CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS == 0 & CLIENT_CACHE_PAGE_READ_EXTERNAL_TIME_NS > 0

  2. When read from cache (or cache hit?), CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS > 0 & CLIENT_CACHE_PAGE_READ_EXTERNAL_TIME_NS == 0

Does this PR introduce any user facing changes?

na

alluxio-bot commented 1 month ago

Automated checks report:

Some checks failed. Please fix the reported issues and reply alluxio-bot, check this please to re-run checks.

alluxio-bot commented 1 month ago

Automated checks report:

All checks passed!