search

Alluxio / k8s-operator

An operator for managing Alluxio system on Kubernetes cluster
https://www.alluxio.io/
Apache License 2.0
10 stars 8 forks source link

Fix serviceAccountName #18

Closed ssz1997 closed 1 year ago

ssz1997 commented 1 year ago

A followup to https://github.com/Alluxio/k8s-operator/pull/12. That PR changed the name of the serviceAccount but didn't update in the CSI configurations.

Kai-Zhang commented 1 year ago

btw, are the automated tests adequate for this problem? i mean with the existing automated tests we could have found this problem in #12, right?

ssz1997 commented 1 year ago

Good question. This string is actually hard-coded everywhere so the test would not catch it, not to mention PR #12 doesn't have the test implemented yet. Let me make it non-hardcoded.

ssz1997 commented 1 year ago

@Kai-Zhang PTAL. Thanks!