search

Alluxio / k8s-operator

An operator for managing Alluxio system on Kubernetes cluster
https://www.alluxio.io/
Apache License 2.0
11 stars 9 forks source link

Remove nameOverride from config #8

Closed ssz1997 closed 1 year ago

ssz1997 commented 1 year ago

Remove nameOverride from helm chart. The reason lies in the implementation of operator:

  1. The fullname of the alluxio cluster depends on the nameOverride, according helm chart logic.
  2. The name of a load job will include the fullname of the alluxio cluster, so that the user would be able to know which data the job is loading.
  3. The load crd, which provides the parameters to launch underlying load job, only has the name of the alluxio cluster as a parameter. So to construct the underlying load job name, we grab the alluxio cluster, find nameOverride, and then construct the fullname.
  4. When we destroy the underlying load job, the request doesn't contain the name of the alluxio cluster anymore, and thus there's no way for us to find the name of the underlying load job.
  5. Therefore, by removing nameOverride, the name of the underlying load job doesn't depend on the nameOverride anymore, and thus we are able to find and delete the underlying load job.
  6. nameOverride should not be modified in usual case anyways.
ssz1997 commented 1 year ago

@Kai-Zhang PTAL. Thanks!

ssz1997 commented 1 year ago

Nvm the fullname still depends on the name of the alluxio cluster. The only solution is to make the load job name doesn't contain the alluxio cluster name.