AllwineDesigns / stl_cmd

stl_cmd - commands for binary STL file manipulation
Other
50 stars 9 forks source link

Overflow issue on large ~5GB files #9

Closed bartoszek closed 3 years ago

bartoszek commented 3 years ago

num_tris has to be casted to uint64_t here to prevent overflowing when calculating size for stl with ~100M triangles. https://github.com/AllwineDesigns/stl_cmd/blob/5d1c0a24387e174e41d4c964703b455e974286c9/src/stl_util.h#L303

jallwine commented 3 years ago

Good catch! Did you run into this problem or were you just looking through the code?

bartoszek commented 3 years ago

I was doing some synthetic tests for 3d printer manufacturer and stl_marge strangely stopped working for me.