AllynH / destiny_focus

A Destiny the game web application, helping you focus on improving your PvP or PvE game.
MIT License
4 stars 0 forks source link

Character select missing #7

Closed rtroberts closed 2 years ago

rtroberts commented 2 years ago

Allyn, really appreciate all the hard work you've put into this! What a useful tool.

For me, the character select box is always empty white, like the following: image

Perhaps because /auth/get/get_characters is returning a 500.

Hopefully I'm not wasting your time with a spurious, temporal issue, but I figured I'd report it anyway.

AllynH commented 2 years ago

Hi @rtroberts

I've been looking through the gunicorn log files and it seems Bungie were returning some strange errors. I checked out Bungie Help on Twitter and saw they were doing some maintenance at the time. Bungie's servers do some strange stuff in maintenance mode and there are no real standard errors.

So I'm hoping this is all related to the maintenance mode but I've added an additional check in the auth flow for this error. Code pushed, it'll be deployed shortly.

Bungie help Tweet:

https://twitter.com/bungiehelp/status/1523709380859936771?s=21&t=Dtvuh5JkI4alA0o5mF9coA

Can you check back shortly and see if it's resolved? Maintenance is still running for about 30 minutes.

AllynH commented 2 years ago

Code commit:

https://github.com/AllynH/destiny_focus/commit/0520d94a66cf74240a602cc4f21bf08e135662a3

rtroberts commented 2 years ago

I can successfully make a request like https://www.bungie.net/Platform/Destiny2/2/Profile/4611686018436793293/?components=102%2C103%2C200%2C201%2C205%2C300%2C305%2C310, which if I am reading the code correctly, /get/get_characters is using. However, that endpoint is still throwing a 500 error for me, so perhaps it's something else.

AllynH commented 2 years ago

Can you check your privacy settings here:

https://www.bungie.net/7/en/User/Account/Privacy

image

rtroberts commented 2 years ago

image

Of course, here it is!

rtroberts commented 2 years ago

I could also upload the results of the Profile call in a file (it's rather large) if it could be a parsing issue.

AllynH commented 2 years ago

image

Of course, here it is!

You'll need to enable "show my non-equipped inventory". I make a call to get your profile information, which is the same API endpoint as your inventory.

Essentially all character information, including your inventory, is accessed via that endpoint.

rtroberts commented 2 years ago

Interesting. I did try turning that on, logging out, hard refreshing, and logging back in - to no effect.

AllynH commented 2 years ago

I could also upload the results of the Profile call in a file (it's rather large) if it could be a parsing issue.

Can you try to post this to a private gist and I'll have a look?

https://docs.github.com/en/get-started/writing-on-github/editing-and-sharing-content-with-gists/creating-gists#creating-a-gist

rtroberts commented 2 years ago

It's not private but it's only Destiny, I don't mind sharing :)

https://gist.github.com/rtroberts/603931bf2ce518a7b6961d0415b5ed47

As mentioned in the gist, this should include the same components used in the code (100, 200, 202, 204)

jtwee commented 2 years ago

I'm having the same issue. Is there anything I can contribute to see what may be consistent with our profiles?

AllynH commented 2 years ago

It seems there was a strange issue in the Risen title DestinyRecordDefinition where it doesn't include an icon (displayProperties["icon"]) for that title. This was causing a 500 error in my code, as the value is returned to the user.

https://data.destinysets.com/i/Record:1710217127

This has been fixed now, please try again.

Cc @jtwee

AllynH commented 2 years ago

Commit:

https://github.com/AllynH/destiny_focus/commit/9c30c8713ad09fde9576353f78bb57cf18479177

rtroberts commented 2 years ago

Wow, weird. This commit has resolved the issue for me. Thanks for the help, @AllynH!

AllynH commented 2 years ago

Delighted to hear that, thanks for logging the issue. @jtwee also messaged me to say it's working for them. Hope you enjoy the app, let me know if there's anything else that needs fixing.