search

AlmaLinux / Hardware-Certification-Suite

3 stars 6 forks source link

Deprecated include syntax used in Ansible #7

Open grooverdan opened 10 months ago

grooverdan commented 10 months ago 
$ ansible-playbook -i 192.168.122.191, automated.yml --tags isv-mariadb

changed: [root@192.168.122.191 -> localhost]
ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.
$ ansible --version
ansible [core 2.16.0b2]
  config file = /home/dan/repos/Hardware-Certification-Suite/ansible.cfg
  configured module search path = ['/home/dan/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.12/site-packages/ansible
  ansible collection location = /home/dan/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/bin/ansible
  python version = 3.12.0 (main, Oct  2 2023, 00:00:00) [GCC 13.2.1 20230918 (Red Hat 13.2.1-3)] (/usr/bin/python3)
  jinja version = 3.1.2
  libyaml = True
xsub commented 7 months ago

@grooverdan Thanks for creating this, I just had the same intent!

xsub commented 7 months ago

Hi @dlutczyk,

We recently talked about your willingness to help AlmaLinux OS from development side, so how about this one? Does this seem as interesting enough to try?

Regarding the test system I will provide you access to a remote machine in my office-lab that is suitable for development and testing.

Let me know your thoughts, thanks!

dlutczyk commented 7 months ago

Hi @xsub Sure, I'd be happy to help. I could start in the 2nd week of February (i.e. after 5th), so if that's not too late, please sign me up!

grooverdan commented 5 months ago

Hi @dlutczyk, are you available to look at this?

dlutczyk commented 5 months ago

Hi @grooverdan, I will be available next week (after April 2nd).

dlutczyk commented 3 months ago

Hi @grooverdan! If you're interested - I made some changes and as for now they are in my fork of Hardware Certification Suite.

I changed the deprecated includes: https://github.com/dlutczyk/ALMA-Hardware-Certification-Suite/commit/3cee674f3a4219d40396b47a13fd28c5477cfa60

Also fixed 2 other problems encountered during tests:

Unfortunately, these haven't gone through any review process (there were no pull requests created).