AlmaLinux / almalinux.org

almalinux.org official web site sources.
https://almalinux.org
Creative Commons Attribution Share Alike 4.0 International
39 stars 49 forks source link

Updates to the downloads page #579

Closed sboldyreva closed 3 weeks ago

sboldyreva commented 3 weeks ago
codyro commented 3 weeks ago

https://293f368c.almalinux-org.pages.dev/get-almalinux

This is only loosely related, but while you're making modifications, can you fix the Download buttons to use a relative link? :D

bennyvasquez commented 3 weeks ago

https://293f368c.almalinux-org.pages.dev/get-almalinux

This is only loosely related, but while you're making modifications, can you fix the Download buttons to use a relative link? :D

That's actually housed in a whole separate file, so I'd argue it should be done in a different PR. This looks good to me, and I know @sboldyreva's done for today, so I'm going to merge this one in and we can fix the direct v relative links in another one.

sboldyreva commented 3 weeks ago

@codyro not sure I can see the issue. The "Download" buttons on the website lead to the Get-AlmaLinux page as they should. The "Download" links in images (Raspberry Pi for example" lead to a general directory with updated images. Though would you rather I put the exact links with AlmaLinux versions (example: https://repo.almalinux.org/almalinux/8.10/raspberrypi/images/)?

If that's not what you meant, can you please share more details/screenshots?

codyro commented 3 weeks ago

@sboldyreva I'm Sorry. My explanation was very ambiguous and not helpful (and very loosely related to this PR, as benny noted).

When I visited the preview URL here, https://293f368c.almalinux-org.pages.dev/, I clicked the green Download buttons at the top right/center of the page to look at your changes. I noticed that it was linking to the absolute URL (https://almalinux.org/get-almalinux) instead of the relative URL (https://293f368c.almalinux-org.pages.dev/get-almalinux).

I was just noting it in this PR to ask if you could fix it up as it was tangentially related. However, since this has already been merged in, we can just make a new issue/PR.