After the initial implementation of the OVAL data generator, I didn't take into account that we were going to migrate the already released erratas' oval data, which brought a couple of problems:
When creating states, we aren't checking if the state is in oval cache
AlmaLinux production OVAL contains non-critical (but awful) reference inconsistencies (looks like we have a debranding issue in our current get_xml_oval processing), i.e.:
<criterion test_ref="oval:org.almalinux.alsa:tst:20243466001" comment="python39 is earlier than 0:3.9.19-1.module_el8.10.0+3849+a48d89aa"/>
This criteria refers to test oval:org.almalinux.alsa:tst:20243466001:
<red-def:rpminfo_test check="at least one" comment="python39 is earlier than 0:3.9.19-1.module+el8.10.0+21815+bb024982" id="oval:org.almalinux.alsa:tst:20243466001" version="636">
<red-def:object object_ref="oval:org.almalinux.alsa:obj:20214160001"/>
<red-def:state state_ref="oval:org.almalinux.alsa:ste:20243466001"/>
</red-def:rpminfo_test>
The problem here is that the evr in the comments don't match, 0:3.9.19-1.module_el8.10.0+3849+a48d89aa (alma) vs 0:3.9.19-1.module+el8.10.0+21815+bb024982 (rhel)
And if we go further and check the state oval:org.almalinux.alsa:ste:20243466001:
For that to not happen again, when processing a new test, we need to, in addition to check that both object_ref and state_ref match, check that the comment also matches.
After the initial implementation of the OVAL data generator, I didn't take into account that we were going to migrate the already released erratas' oval data, which brought a couple of problems:
This criteria refers to test
oval:org.almalinux.alsa:tst:20243466001
:The problem here is that the
evr
in the comments don't match,0:3.9.19-1.module_el8.10.0+3849+a48d89aa
(alma) vs0:3.9.19-1.module+el8.10.0+21815+bb024982
(rhel)And if we go further and check the state
oval:org.almalinux.alsa:ste:20243466001
:For that to not happen again, when processing a new test, we need to, in addition to check that both
object_ref
andstate_ref
match, check that the comment also matches.