search

Almad / django-sane-testing

Django integration with nose, Selenium and more
https://github.com/Almad/django-sane-testing
Other
59 stars 8 forks source link

It seems like selenium_patched_open() works wrong. #10

Closed real-alexei closed 13 years ago

real-alexei commented 13 years ago

https://github.com/Almad/django-sane-testing/blob/master/djangosanetesting/utils.py#L175 looks unreachable and I think this line should replace line 168.

yedpodtrzitko commented 13 years ago

Original functionality will be achieved by deleting 'return' from line 168.

Almad commented 13 years ago

Thanks for catching this, this is what we get for defunct tests :) (is_text_present must be asserted...).

Almad commented 13 years ago

Refactor tests, expose nonworky selenium code. Closed by 58ad092d59357899958a9d6f801aff6f7925e3c3

Almad commented 13 years ago

(also, #3 reopened)