Almamu / linux-wallpaperengine

Wallpaper Engine backgrounds for Linux!
GNU General Public License v3.0
1.51k stars 56 forks source link

[BGFIX] Failed to load scene.pkg file: Unsupported package version: PKGV0019 #185

Closed avidwriter closed 7 months ago

avidwriter commented 9 months ago

Wallpaper Engine Background(s)

https://steamcommunity.com/sharedfiles/filedetails/?id=3047352572

Console output

Failed to load scene.pkg file: Unsupported package version: PKGV0019

Screenshots

If you have any screenshot of it working on Windows that'll help so we can compare both outputs

Desktop (please complete the following information):

Additional context

installed from git

Iss-in commented 9 months ago

same issue with multiple backgrounds, 3048130917, 3050040845

trainzkid commented 8 months ago

In src/WallpaperEngine/Assets/CPackage.cpp, during the header validation process (function CPackage::validateHeader, line 97), scene-style wallpapers are checked to see which "version" of ".pkg" file type (specific to scene-style wallpapers) they use. This app appears to only support wallpaper engine's ".pkg" file type versions 1 through 18. Anything else causes the aforementioned error.

I'm not entirely sure what logic is tied to each version, but I'll keep digging (unless another contributor provides some more context here, as I'm just perusing through the cpp files to get some sort of idea, I'm no expert).

TLDR: These scene-style wallpapers use a newer/different version of pkg file type structure that this app doesn't appear to support just yet

lovanto commented 7 months ago

i got the same problem too

Almamu commented 7 months ago

I've changed the header validation to only care about PKGV and ignore the number. In theory the behavior should change between versions, but I haven't found any situation where it really matters yet. So this should be fixed now and for the future as long as the PKGV part is the same.