Almamu / linux-wallpaperengine

Wallpaper Engine backgrounds for Linux!
GNU General Public License v3.0
1.6k stars 60 forks source link

[Feature Request] wallpaper resize to fit #90

Closed arthurmelton closed 10 months ago

arthurmelton commented 2 years ago

I personally would really like a feature like this because one of my monitors are 1920x1200 so its harder to find wallpapers I like that fit to that resolution, this is an example of what currently happens image and this is what it should look like image It would be really nice if the image could resize so it would fit on my monitor, this also gets referenced as zoomed fill and if this is a bug this is what I am using

Almamu commented 2 years ago

Could you share the workshop id or a link of the wallpaper so I can look closer into it? I do have some 1200p panels to try this.

arthurmelton commented 2 years ago

well this happens for every wallpaper that is not 16:10 (because I have a 16:10 monitor)

arthurmelton commented 2 years ago

here is the link https://steamcommunity.com/sharedfiles/filedetails/?id=1134328086 though

Almamu commented 2 years ago

I've looked at some backgrounds designed for different aspect ratios and all scale to fill the current screen space available so there's no blackbars, that's why the wolf's background looks bigger. I can implement different scaling modes so you can alter this behaviour, with the cost of having extra black bars either on top or on the sides, but I don't see any other option.

arthurmelton commented 2 years ago

So the result I was thinking about is to make it so it has the black bars but then zoom in so you wont see the black bars, this will make it so you cant see as much of the wallpaper but then no black bars.

Almamu commented 2 years ago

That's how it should be working right now. This is how it looks in my 1080x2556 screen: image

And this is how it looks on a 1080p display: image

Unless I'm missing something the background is scaled in both directions to fill the longer side of the display, so there's no black bars.

arthurmelton commented 2 years ago

No, I mean that it will keep the same ratio but it will zoom in so it does not have black bars so instead of it being streached it would look like image so you wont be able to see the edges but it will look normal and have the same ratio

Almamu commented 2 years ago

It should be keeping the right aspect ratio, but looks like something in my calculations is not right. This might be related to #81 too as It just dawned on me that the only way for a background to look pixelated is to have some kind of scaling being applied, and the different sizes is the only way for that to happen.

Pasalc commented 10 months ago

@arthurmelton Hello, if you're still using this software, could you check that this pull request works for you? You should be able to run zoom fill like this: ./wallengine --scaling fill --screen-root YOUR_SCREEN 1134328086

arthurmelton commented 10 months ago

I actually don't use this software anymore and don't have a steam account to use the software anymore. I will promptly close this issue as I am not following this issue anymore.