search

Almenon / AREPL-vscode

Program python in real-time
MIT License
263 stars 32 forks source link

Replace renderjson #255

Open ZainlessBrombie opened 5 years ago

ZainlessBrombie commented 5 years ago

The renderjson library is extremely simplistic and the external dependency is causing only issues, imo. I'll see that I'll rewrite it, with support for long lists and big numbers. At the time of writing this, the project is not compiling so I need to wait for that :)

ZainlessBrombie commented 5 years ago

219 #238 #176 #172

Yes that issue basically already exists: #97 oops

Almenon commented 5 years ago

When you say the project is not compiling do you mean arepl-vscode?

ZainlessBrombie commented 5 years ago

@Almenon yes, I'll copy the message I sent you on reddit:

Hey there! :)

You invited me to contribute to AREPL recently, but I've pulled the repo and it is not running. The multi type array [type1, ...any[]] is used (available ts 3.x) but the package.json is at 2.x. Also, another piece of code works only in ts 3.0.1, because there was a breaking change in 3.1 that lets You no longer use boolean operators on void, we might want to upgrade to the newest version, it shouldn't need much adjustment. There is also line 7 in src/env/types.ts which references ./application/commands, which does not exist (probably not commited?). Could You, in a seperate directory, check out the repository and do a clean install and build to see what is missing?

Thanks! :)

Almenon commented 5 years ago

I'll get on that, thanks for letting me know.

Almenon commented 5 years ago

damn you're right, I've been using the wrong typescript version.

https://i.imgur.com/S4Hccg6.png

ZainlessBrombie commented 5 years ago

:see_no_evil:

Almenon commented 5 years ago

backend compilation is also failing, leme fix that too.

Almenon commented 5 years ago

@ZainlessBrombie done, both repos should work out-of-box now :)

ZainlessBrombie commented 5 years ago

@Almenon Lovely! I'm at work rn but I'll see that I get started doing some stuff :) This is the sixth project I have in parallel so I need to mange resources a little, but I'll see that I can get some decent chunks :+1:

Almenon commented 5 years ago

BTW big number support would be implemented outside of renderjson, in the handling of the response from the python code or in the python code itself.