AlmirKadric-Published / docker-tuntap-osx

A tuntap shim installer for "Docker for Mac"
MIT License
332 stars 65 forks source link

"The hyperkit executable file was of an unknown type" when installer is run twice #20

Closed pts-rajperera closed 5 years ago

pts-rajperera commented 6 years ago

This is most likely related to #4

I ran in to this issue as well trying to run the install script twice. The error "The hyperkit executable file was of an unknown type" seems to be coming from the installer script because it checks the file type of the of the hyperkit shim by using the file command. In my machine the output of the command is

$ file /Applications/Docker.app/Contents/Resources/bin/hyperkit                                                                                                           
/Applications/Docker.app/Contents/Resources/bin/hyperkit: Bourne-Again shell script text executable

and the script checks for https://github.com/AlmirKadric-Published/docker-tuntap-osx/blob/master/sbin/docker_tap_install.sh#L66

if file "$hyperkitPath" | grep -q 'executable, ASCII text$'; then
AlmirKadric commented 6 years ago

ah right, that is indeed an issue, I'll try and get it fixed over the next few days if you can't wait, mind making a PR? I'm more than happy to review it

AlmirKadric commented 5 years ago

this should be fixed in the latest commit do you mind pulling and trying again?

AlmirKadric commented 5 years ago

will close due to inactivity, if anyone has this problem again please make another issue