AlmirKadric-Published / docker-tuntap-osx

A tuntap shim installer for "Docker for Mac"
MIT License
332 stars 65 forks source link

fix some command #8

Closed gingerhot closed 6 years ago

gingerhot commented 7 years ago
  1. route add need sudo
  2. tuntap was migrated to cask
AlmirKadric commented 6 years ago

Apologies on the late review and merge, last few months have been somewhat crazy for me. Thanks for the contribution!!!! This being said, after some merging i've done, some merge conflicts have arisen. If you could fix them and the 1 comment I left above, I'm more than happy to merge this!

gingerhot commented 6 years ago

I didn't notice the #5 is about the tuntap when I created this pull request, now it has been merged so I think no need to merge mine(the other one about sudo could be left for the users). Thanks~

AlmirKadric commented 6 years ago

Thanks for the quick response! Understood and thanks once again ^_^