AlmostIntelligent / Hydra

A distributed computation network.
4 stars 0 forks source link

Configuration hierarchy to complex #12

Closed Cikey closed 12 years ago

Cikey commented 12 years ago

There should be one interface that defines all public configuration methods in one place. This interface can then be implemented by Config and ConfigSecureWrapper. This should prevent obfuscated calls to service context:

@Override
public final ConfigurationGetter getConfigurationGetter() {
    return new ConfigurationSecurityWrapper(cfg);
}

@Override
public final ConfigurationSetter getConfigurationSetter() {
    return new ConfigurationSecurityWrapper(cfg);
}

Should be:

public final Configuration getConfiguration() {
    return new ConfigurationSecurityWrapper(cfg);
}
hastern commented 12 years ago

As a first solution, I moved some classes into a sub packages.

Cikey commented 12 years ago

Done, merged getter and setter interfaces.