AlmostReliable / almostunified

A Minecraft mod to unify resources.
https://www.curseforge.com/minecraft/mc-mods/almost-unified
GNU Lesser General Public License v3.0
50 stars 9 forks source link

TerraFirmaCraft - tfc:damage_inputs_shapeless_crafting recipes not being unified #77

Open AirRice opened 2 months ago

AirRice commented 2 months ago

Minecraft Version

1.20.1

Mod Version

AlmostUnified-Forge-1.20.1-0.9.2 TerraFirmaCraft 3.2.1 Firmalife 2.1.0

Describe the feature/addition!

I am unsure if this is a bug or simply not implemented, but I have been trying to unify tfc:powder/salt. TFC's nested tfc:damage_inputs_shapeless_crafting JSON recipe format does not seem to be properly unified and the recipe still uses the hardcoded original ingredients. For further information such a recipe is Firmalife's recipes added using this JSON format (example: https://github.com/eerussianguy/firmalife/blob/1.20.x/src/main/resources/data/firmalife/recipes/crafting/bacon.json)

I would like for this to work.

Why would like to see this feature/addition?

https://github.com/AlmostReliable/almostunified/commit/7ff762b9987dbb817cd92427769c16548268c380 added a number of TFC compatibility but as far as I could tell tfc:damage_inputs_shapeless_crafting recipes does not get unified (Either that or Firmalife's implementation of them is somehow messed up). I assume this is due to it being a nested recipe format but I do not know enough of the 1.20.1 forge codebase to make sense of it.