search

AlmostReliable / summoningrituals

A Minecraft mod to create custom summoning rituals for items and mobs.
https://www.curseforge.com/minecraft/mc-mods/summoningrituals
GNU Lesser General Public License v3.0
10 stars 5 forks source link

[BUG] Adding multiple Sacrifices break recipes #8

Closed TheonlyTazz closed 2 years ago

TheonlyTazz commented 2 years ago

Version

summoningrituals-1.18.2-1.1.3.jar

Describe the bug!

Basicly trying to add 3 withers to sacrifice using .sacrifice('3x minecraft:wither') will cause it not to work image

adding 3x, .sacrifice('minecraft:wither') image

it does add the sacrifices, but only kills one

Crash Report

no crash report

Log

no log?

Additional Context

Yes

Modifications

tested this in Inferno, havent tested on a isolated instance

Did the issue happen in singleplayer or on a server?

Singleplayer

rlnt commented 2 years ago

This is normal because the '3x minecraft:wither' is invalid syntax. I mentioned this part on the wiki here. The way you add multiple sacrifices is different than that for items. So if you want to avoid having the sacrifice statement 3 times, you can use .sacrifice('minecraft:wither', 3).

The reason behind that is that I use native KubeJS bindings for items that provide the syntactic sugar like '3x stone' but since there is no entity wrapper in KubeJS, the implementation works a bit differently.

Edit: the part with the wrapper is actually explained on mob outputs but it's the same for sacrifices and I listed examples for this case https://github.com/AlmostReliable/summoningrituals-forge/wiki/Recipes#mob-outputs

TheonlyTazz commented 2 years ago

seems im just blind, thanks relentless