search

Almoullim / background_location

Flutter background location plugin for Android and iOS
https://pub.dev/packages/background_location
Other
224 stars 236 forks source link

add fallback for LocationManager in case google api is not available #101

Closed arboss closed 3 years ago

arboss commented 3 years ago

… fixes #69 and fixes #14

If FusedLocationProvider is not available because of missing google play services on the device, this change will cause the plugin to fall back onto LocationManager.

This was my first time writing kotlin code, so it might need improving and it definitely needs more testing. Also i was only able to test this on a device without google play services.

Almoullim commented 3 years ago

is this ready?

MoralCode commented 3 years ago

I think it would be helpful if this also added an option like forceAndroidLocationManager in https://pub.dev/documentation/geolocator/latest/geolocator/Geolocator/getPositionStream.html that people could use to opt into using locationManager over the google play version.

I'm curious if the original usecase for this PR (where google play is not available) is something that can be known by the developer in advance (i.e. intentionally releasing an app on a platform like lineageOS or another pro-privacy OS that doesnt use google play services. If so, I think this forceAndroidLocationManager parameter might be able to replace the checks in this PR to see if google play is available.