search

AlmuraDev / Almura

The official mod of the Almura Client and Server.
http://www.almuramc.com
Other
16 stars 10 forks source link

Ores always rendering with in spectator mode #525

Closed Dockter closed 5 years ago

Dockter commented 6 years ago

A user brought up a good question that after digging into I don't have an answer to.

When in spectator mode it appears that our ORES always render, which means even if the client isn't needing to rendering these deep in a chunk its still doing it.

I tried several things since these are HORIZONITAL blocks to try and solve the issue, from setting the render type to solid, to setting Block_shape_face to solid, even tried reversing some logic in the HorizontalBlockImpl file to try and get them to hide properly and I couldn't seem to get it to work as intended.

Any ideas?

TherayTharow commented 6 years ago

this 2018-10-08_20 58 05

liach commented 6 years ago

are ores opaque?

TherayTharow commented 6 years ago

yes the texecher is the block no it acts like glass

liach commented 6 years ago

i am meant to ask doc not you, uh

TherayTharow commented 6 years ago

to the point that if you reskin it to glass you can't tell the differends

liach commented 6 years ago

The exact cause: https://github.com/AlmuraDev/Almura/blob/686562e58bb70306d896573346c6c395fc62cafc/src/main/java/com/almuradev/content/type/block/type/horizontal/HorizontalBlockImpl.java#L139-L141

TherayTharow commented 6 years ago

Can you have it to where it can be set in side of the file that sets the hardens (can't think of what it was called) and when it does not find it set it as true

liach commented 6 years ago

Not yet. It needs some time for the hooks exposed to the content system. Wait a bit.

Dockter commented 5 years ago

@liach I tested this return TRUE for both isOpaqueCube and isFullCube and they still appeared during spectator mode. Any idea's?

Dockter commented 5 years ago

Fixed in https://github.com/AlmuraDev/Almura/commit/c4e0289fd513d56bdbf04c8dc366a9e7e56777c4