search

AlmuraDev / Almura

The official mod of the Almura Client and Server.
http://www.almuramc.com
Other
16 stars 10 forks source link

Issues with ObjBakedModel -> getQuads in certain scenarios #537

Closed Dockter closed 4 years ago

Dockter commented 4 years ago

We have some logical issues with the above method in the following scenario.

  1. OBJModel has 6 sides.
  2. isOpaque in Content File is set to True (enables face culling).
  3. light:opacity = 255 (which means light shouldn't pass through).

If you edit a horizontal block for example: /content/block/horizontal/building/bricks_block_b_sbrick1.json

"opaque": false, "light": { "emission": 0.0, "opacity": 255 },

Now go into single player, turned "Smooth lighting off", place down 4 of the above blocks one in each facing direction. Once you do this you'll see the error.

Dockter commented 4 years ago

Turning Opaque to false, fixes the wrong face getting culled. Turning opacity to 0 from 255 fixes the lighting error.

Dockter commented 4 years ago

I'm closing this issue because I don't see it ultimately getting fixed until we move to a newer obj renderer.