AlmuraDev / SGCraft

Stargates mod for Minecraft
https://www.almuramc.com/sgcraft/SGCraft.html
MIT License
31 stars 29 forks source link

Cannot break blocks #115

Closed ExDomino closed 4 years ago

ExDomino commented 4 years ago

Stargate blocks and Dhd cannot be picked up with any pickaxe, even dimond ones. Blocks are always lost.

ExDomino commented 4 years ago

I found that is a config in the option. But there is a problem: a misplaced block cannot be moved. I suggest you two modifications:

1) Silktouch can break blocks. 2) You can harvest the DHD and a ring block without silktouch if the stargate is not completed. 3) A non harvestable block should take as long as without tool to harvest it.

For the second suggestion, I mean incomplete stargates ring blocks, for example a misplaced one, can be picked up, but when the stargate is complete, only silktouch can break them in order to retrieve the block. For the third suggestion, it is to inform the player that their will not get the block.

Dockter commented 4 years ago

I think I have a better idea. Only mark the blocks as un-harvestable AFTER the gate is initially created.

Dockter commented 4 years ago

OK, so that idea wont work because blocks are singletons. So, what I think I may do is allow people to turn these values to true but add an additional check to prevent the player to break a gate if its assembled.

ExDomino commented 4 years ago

Yes, except if you have silktouch.

Dockter commented 4 years ago

Nah, I'm working on a better idea. My goal of this is to prevent users from harvesting structure generated gates.

Ezoteric commented 4 years ago

you could also do it like Actually Additions does its decoration machines in the village house, you can use them but once you break them they are gone :)

Dockter commented 4 years ago

This feature I talked about above was implemented.