AlmuraDev / SGCraft

Stargates mod for Minecraft
https://www.almuramc.com/sgcraft/SGCraft.html
MIT License
31 stars 29 forks source link

[Suggestion] shader portal animation #122

Closed ben-mkiv closed 4 years ago

ben-mkiv commented 4 years ago

Hello,

i've recently started to make a sg-craft inspired portal for one of my mods, which uses Shaders for the Portal animation. Today i've noticed that SG-Craft was ported to 1.12.2...

https://www.youtube.com/watch?v=ss40Gu-x-qA

I would implement it as optional feature and make a PR if you are interested in that.

It comes with some flaws caused by minecraft render engine, thats why i would suggest to make it an optional feature (using a TESR and so the rendering isn't depth sorted, which can conflict with other TESRs (they get invisible behind the portal animation)

https://www.shadertoy.com/view/4tsXRH

Dockter commented 4 years ago

Yes, I'm interested!

Dockter commented 4 years ago

No reply, closing ticket.

ben-mkiv commented 4 years ago

sorry for the late reply, it's still somewhere on my todo list, however it currently has low priority.

I'll make an PR when its done