AlmuraDev / SGCraft

Stargates mod for Minecraft
https://www.almuramc.com/sgcraft/SGCraft.html
MIT License
31 stars 29 forks source link

Gradle is still broken , does not download dependencies and does not compile #134

Closed Tsoccerguy3 closed 4 years ago

Tsoccerguy3 commented 4 years ago

Some of these links are broken , It a scavenger hunt to locate the dependencies , the build.gradle needs to be fixed .

BUILD FAILED in 35s

C:\Users\ASUS\Dev\sgc>gradlew build

Configure project : This mapping 'snapshot_20180808' was designed for MC 1.12! Use at your own peril.

FAILURE: Build failed with an exception.

Dockter commented 4 years ago

Fixed.

dallenwilson commented 4 years ago

My apologies for commenting on a closed issue; I judged it better than opening a new one, as the problem is identical and it was only recently closed.

I'm seeing exactly the same missing dependency errors with everything that was added for cofh testing in commit 07dbfa7.

Using ThermalDynamics as an example, build.gradle has: deobfCompile "cofh:ThermalDynamics:1.12.2-2.5.5.21:universal" which causes it to try to download http://maven.covers1624.net/deobf/cofh/ThermalDynamics/1.12.2-2.5.5.21/ThermalDynamics-1.12.2-2.5.5.21.jar

That file does not exist, and in fact the whole http://maven.covers1624.net/deobf/ does not exist. But there is a deobf jar file at https://maven.covers1624.net/cofh/ThermalDynamics/1.12.2-2.5.5.21/ThermalDynamics-1.12.2-2.5.5.21-deobf.jar

Changing the line in build.gradle to compile "cofh:ThermalDynamics:1.12.2-2.5.5.21:deobf" resolves the error, downloads the new file and the process continues.

After making the same change in build.gradle for all the new deps, I was able to compile the mod. It appears to load and run fine in minecraft.

I have a fair bit of programming experience, but have never used java or gradle. I don't know what other problems changing from deobfComplie to compile may cause. I can submit a PR with the changes, if you'd like.