AloisSeckar / WBSC-Scoring

Visualisation tool for WBSC scoring system
The Unlicense
2 stars 2 forks source link

Rendering play resets constraints on pos selection in useEvalStore #257

Closed AloisSeckar closed 4 days ago

AloisSeckar commented 2 weeks ago

When play is selected, min/target/max pos items are correctly evaluated on background: image

However, once "Score play" is hit, the store resets (probably?) and +/- buttons can get into invalid state image

Remove can be clicked and there is no way to recover image

We need to preserve useEvalStore min/target/max pos items state when rendering output.

To prevent introducing another regression, be careful not to preserve something that should reset on the other hand...

AloisSeckar commented 2 weeks ago

Secondary issue - when user first picks from pos select, number of rendered pos selects reverts to "target pos items"

AloisSeckar commented 4 days ago

both issues should be fixed now