Alonski / CoinPanion

CoinPanion
MIT License
7 stars 1 forks source link

Create New Profile #2

Closed Alonski closed 7 years ago

Alonski commented 7 years ago

Allow a user to create their profile: Authentication can be done completely with the blockchain using Ethereum Address: MetaMask, Mist, Status

Features:

We can also just make the whole page Markdown for the MVP

rhlsthrm commented 7 years ago

Pictures? I think one profile picture is enough for the MVP. We should keep the profile as simple as possible.

Alonski commented 7 years ago

I meant this as the main page for each user. The page where other users go to subscribe to you.

rhlsthrm commented 7 years ago

OK I see. We should also define what "More" is. I think this is one of the more important pages in the MVP so let's define what should be on it.

Alonski commented 7 years ago

Yea I put this here so we can start discussion 😄

Josephrp commented 7 years ago

My 2 cents :KEEP IT ULTRA SIMPLE... and i agree with Alon (i agree with everybody :-) ) Picture, Page Name (displayed), Full Name (used for signature! NOT DISPLAYED), OAUTH, Pictures with an s... why not limit to 3? One entry maybe where the coinpanions gives a rough idea of what range subscriptions they need (interger scale from 1 - 8999 <-- fiscal limit one markdown text box, that's it.

PS... sorry for saying ultra simple, then proposing more functionality... i realise it haha..

Josephrp commented 7 years ago

oh sorry... just realised... we won't be displaying in Euros!! scale is decimal from 1 coinpanion (mili eth) to four hundred and twenty thousand coinpanions (420.000) ...

rhlsthrm commented 7 years ago

This will also need to insert users into the database.

Alonski commented 7 years ago

@rhlsthrm Yea this will connect Eth Addresses with Names, Emails etc for each User

imbaniac commented 7 years ago

@Alonski @rhlsthrm @Josephrp Full user profile schema:

Alonski commented 7 years ago

@imbaniac Looks great!

rhlsthrm commented 7 years ago

@imbaniac I propose we merge id and eth_address and use eth_address as the key. The eth_address should not ever change per user, correct?

imbaniac commented 7 years ago

@rhlsthrm In fact, I think, eth address can be changed. IE, user lost access to wallet or decided to use another address and delete this

rhlsthrm commented 7 years ago

@imbaniac okay got it, so then maybe it makes sense to keep a unique identifier in our own database.

Josephrp commented 7 years ago

I would most likely reccommend changing inbound addresses every inbound transaction :-) feature for status? Was going to put that into How it works page - unless Any one objecto ? On Tue, 6 Jun 2017 at 19:57, Rahul Sethuram notifications@github.com wrote:

@imbaniac https://github.com/imbaniac okay got it, so then maybe it makes sense to keep a unique identifier in our own database.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Alonski/CoinPanion/issues/2#issuecomment-306567027, or mute the thread https://github.com/notifications/unsubscribe-auth/ARXoQG7GMupmdnLNn-c1DatldcXrCc0gks5sBZL0gaJpZM4Nqg9s .

Josephrp commented 7 years ago

XD autocorrect ! Will édit this from home! On Tue, 6 Jun 2017 at 21:28, Joseph Pollack josephrichardpollack@gmail.com wrote:

I would most likely reccommend changing inbound addresses every inbound transaction :-) feature for status? Was going to put that into How it works page - unless Any one objecto ? On Tue, 6 Jun 2017 at 19:57, Rahul Sethuram notifications@github.com wrote:

@imbaniac https://github.com/imbaniac okay got it, so then maybe it makes sense to keep a unique identifier in our own database.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Alonski/CoinPanion/issues/2#issuecomment-306567027, or mute the thread https://github.com/notifications/unsubscribe-auth/ARXoQG7GMupmdnLNn-c1DatldcXrCc0gks5sBZL0gaJpZM4Nqg9s .

rhlsthrm commented 7 years ago

My latest pull request ( #33 ) implements the Edit Profile page. Please review.