search

Alonski / CoinPanion

CoinPanion
MIT License
7 stars 1 forks source link

Figure out how to structure project #28

Closed rhlsthrm closed 7 years ago

rhlsthrm commented 7 years ago

I think we should nest components by functionality and how they will be used, similar to what this article describes: https://medium.com/@alexmngn/how-to-better-organize-your-react-applications-2fd3ea1920f1

We can have top level components and nest components within our "scenes". What do you guys think?

rhlsthrm commented 7 years ago

My latest PR has a first-pass implementation of this structure.

imbaniac commented 7 years ago

It's a good idea for enterprise apps with a ton of components, but for us, it'll be overcomplication. We just don't need to have standalone modules and creating own actions, reducers, and components in each folder will be crazy. Let's follow regular:

Still, we can borrow some ideas from the architecture

rhlsthrm commented 7 years ago

So far I've found it easier working this way but if you guys are used to the traditional methods I'm fine with that.

imbaniac commented 7 years ago

It's easier while we haven't added redux. This post describes a few bad practices and very complicated nested structure.

rhlsthrm commented 7 years ago

OK let's refactor on top of the code I checked in then. On Sat, Jun 3, 2017 at 11:13 PM Tim Reznich notifications@github.com wrote:

It's easier while we haven't added redux. This post https://medium.com/@alexmngn/how-to-use-redux-on-highly-scalable-javascript-applications-4e4b8cb5ef38 describes a few bad practises and very compicated nested structure.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Alonski/CoinPanion/issues/28#issuecomment-306020903, or mute the thread https://github.com/notifications/unsubscribe-auth/AK-r0w3lwNM3vcbnpxLRfj6Lc3iPEmzcks5sAksdgaJpZM4NvPhR .