search

Alonski / realworld-ember

This repository is deprecated. Please visit:
https://github.com/gothinkster/ember-realworld-example-app
5 stars 0 forks source link

Articles #14

Closed Alonski closed 7 years ago

Alonski commented 7 years ago

Added articles model and implemented it in home route. Pagination isn't implemented yet and tags aren't implemented yet. Part of #13

alexlafroscia commented 7 years ago

How is this different than #12?

Alonski commented 7 years ago

Oops it seems that I added the commits from the previous branch to this one. I added Article Model/adapter/serializer and implementation to this. Humans make mistakes when tired 😄

alexlafroscia commented 7 years ago

Feel free to close this and push your additional commit to #12.

Alonski commented 7 years ago

Ok. Can you check what is breaking our Travis CI?

alexlafroscia commented 7 years ago

Yeah, I think it's something to do with ember-simple-auth; it does not see the session service as valid for some reason. I'll look into that when I get home tonight and figure out if there's something we need to do to stub that in acceptance tests.

alexlafroscia commented 7 years ago

I got CI passing again in #16

Alonski commented 7 years ago

Updated the commit with regards to your comments. Hope I did everything right 😄

Alonski commented 7 years ago

Think this looks good? Can we merge this?

alexlafroscia commented 7 years ago

Yeah, I'm fine with this. Thanks for putting up with my standards for pull requests 😅

I'll go and rebase this off of master for you, to makes sure that the tests pass, and then merge it in as long as everything is still passing.