search

Alonski / realworld-ember

This repository is deprecated. Please visit:
https://github.com/gothinkster/ember-realworld-example-app
5 stars 0 forks source link

Set up Prettier to run in ESLint #15

Closed alexlafroscia closed 7 years ago

alexlafroscia commented 7 years ago

Related to #10

Alonski commented 7 years ago

Ok no problem. I might do the same for my company project as well. Do I need to run the linter myself before committing or is it setup to do that automatically?

alexlafroscia commented 7 years ago

Do I need to run the linter myself before committing or is it setup to do that automatically?

It should run automatically as part of ember test since we have ember-cli-eslint installed already. You can add a git hook to run the tests before committing if that's your thing, but either way Travis should catch any issues.

alexlafroscia commented 7 years ago

Rebased to fix merge conflict with the test-fix PR.