search

Alonso-del-Arte / semaphore-svg

Just a simple webpage with a red-green-yellow stoplight
GNU General Public License v3.0
0 stars 1 forks source link

Eliminate need for semaphoreCasing.png #1

Open Alonso-del-Arte opened 10 months ago

Alonso-del-Arte commented 10 months ago

As it stands, this doesn't actually use SVG. Figure out how to use SVG and JavaScript to animate the traffic light.

Soyamprabha commented 10 months ago

please assign me this issue

Alonso-del-Arte commented 10 months ago

Alright, as soon as I figure out how to do that

Soyamprabha commented 10 months ago

please assign me this issue

I have sent the PR

Alonso-del-Arte commented 10 months ago

Looks good, will probably merge tonight

Alonso-del-Arte commented 10 months ago

I merged the pull request, that should count for Hacktoberfest for you. But I'm leaving this issue open, because for now we still need semaphoreCasing.png for reference. I want the stoplight casing to be a color like the stoplights I see in real life.

Soyamprabha commented 10 months ago

Okay . I have changed the stoplights' color. Check it once and let me know if you need further changes.

Alonso-del-Arte commented 10 months ago

I'll look at it on Monday. Have a nice weekend