Aloshi / EmulationStation

A flexible emulator front-end supporting keyboardless navigation and custom system themes.
MIT License
2.08k stars 905 forks source link

Game description text start #141

Closed SuperSirLink closed 10 years ago

SuperSirLink commented 11 years ago

Don't know that this is an issue, but not sure else to look...

I have setup my gamelist.xml for my NES games and I have found for some games, the description text starts at different "heights" (or lines) on the screen. For most games it is about mid screen but some are 1 line below and others 2 or 3. All of my box are images have been resized to 441 high (the width my vary). I have checked the theme.xml and gamelist.xml but can not find what is throwing the text down...

Any ideas as to where to look?

Edit: I think I know what is going on... It looks like the text is aligned to the bottom of the screen, correct? That would explain as why there is such varying gaps between the text and box art... The games where the text is lower also have shorter descriptions.

SuperSirLink commented 10 years ago

I have been playing more with the formatting and had to lower my resolution (720p) for performance gains. But I noticed when I did now I have anomalies at the bottom of each image. If I change back to 1080p it is gone...

Untitled Any ideas on this one?

Aloshi commented 10 years ago

The description text is positioned at getImagePos().y() + mScreenshot.getSize().y() + 12 - e.g. just under the image.

I've been having that weird anomaly too (on my development PC, not the Pi), and as far as I can tell, it has to do with how OpenGL is sampling from the texture. What I believe happens is OpenGL samples from the "top" of the texture when rendering that bottom line, causing the weird single-pixel stripe. It doesn't happen at every resolution presumably because the rounding differs.

I think one fix is to change the texture wrap modes to "clamp to edge" instead of "repeat" for everything like it is now.

SuperSirLink commented 10 years ago

Thanks for the reply! Is that option already in the theme.xml, don't remember seeing that before. In my current. config, there is alot of space between the text and image if there is a short description.

Glad it is just not me! :). Was banging my head against the wall trying to figure out what I was doing. Screen resolution certainly plays into it, tried various image sizes.

SuperSirLink commented 10 years ago

I don't see reference to that in the themes.md, can you elaborate on what that does? do the x y coordinates go in the parenthesis? I looked again at my themes.xml and don't have that for sure... Maybe that is why my text is lower justified?

Aloshi commented 10 years ago

The bit I posted is just the code EmulationStation uses for positioning the description. getImagePos().y() corresponds to <gameImageOffsetY> in a theme. You might also want to try playing around with <gameImageHeight> as that influences mScreenshot.getSize().y().

If I remember right, it used to place descriptions so that they'd reach the bottom of the screen. Are you sure EmulationStation is up to date (it hasn't changed in the last 4 months or so)?

SuperSirLink commented 10 years ago

Gotcha! I will play around with those and see if it helps...

I am running the version that would have been bundled in petrock's 1.9.1 image... Is there a version identifier that I could check? I was going to use the retropie setup script to pull down a new install from source...

Aloshi commented 10 years ago

That should be up to date.

SuperSirLink commented 10 years ago

I did an reinstall from source via the RetroPie script last night... I did manage to shift the image around to where the line on the bottom is gone now... Looks like it actually just shifted the issue to the top, but it is not nearly as visible... Think it is as good as I am going to get it...

I couldn't get the other two tags to work, so I just kept shifting the y variable for <gameImagePos>, ended up with this: <gameImagePos>$infoWidth/2 0.2</gameImagePos>

One last question, is it possible to add line breaks to the text? <p> or <br> didn't seem to work...

Aloshi commented 10 years ago

A normal newline character will work (just press enter in your favorite text editor).

SuperSirLink commented 10 years ago

Ha, figures... I was over thinking it! Thanks so much for all your help!