Aloshi / EmulationStation

A flexible emulator front-end supporting keyboardless navigation and custom system themes.
MIT License
2.08k stars 905 forks source link

Feature: Greater options for slide/fade #260

Open djcross opened 10 years ago

djcross commented 10 years ago

I'm wondering if there is a way to have finer control over the behaviour of the screen transitions.

My ideal situation would be:

I'm trying to dig into the code but I'm a complete n00b at cpp, so any pointers appreciated.

I am using the unstable branch

nilsbyte commented 10 years ago

Hi. I am the UI designer of this project.

  1. The basic concept of the UI is to have a different background image for each system. You could use the same image for each system, but the transition effects would still be there. Continue reading at 3.
  2. As it's additional information, I think it's nice to hide it at first. But I will think about it and discuss this with @Aloshi.
  3. and 4. You can set the transition in the main menu under 'UI SETTINGS'. It's either fade or slide. It would be inconsistent to be able to change transitions for each screen. What I would find useful is a third option 'none' to disable transitions completely.
djcross commented 10 years ago

Thanks for the quick response @nilsbyte :)

  1. I figured that much, but I'm keen to look at changing this behaviour on my install. I'm wondering at the moment if commenting out lines 205-248 in es-app/src/views/SystemView.cpp would achieve this. I'm trying a compile now but I'm not too hopeful due to this being the first cpp project I've looked at. Will keep tinkering though and see how I go. tedious work when I am waiting for slow compiles on my pi ;)
  2. Is there a functional reason for this (like it takes x seconds on average to read the file count with n number of roms?), or just a UI opinion? I figure I can just change line 197 of es-app/src/views/SystemView.cpp to be a much lower value than 2000 would be preferable for me.
  3. & 4. I like the slide between the game lists, but when entering the game list, in my opinion, the upward slide is ugly. I feel that a fade here would work much better. I'm wondering about changing playViewTransition in es-app/src/views/ViewController.cpp - in my case I could potentially compile without the if so that it always uses fade.

I also think that a 'none' would be a nice options for a transition effect, but I feel that it might actually be simpler to just allow the changing of the fade effect times inside a theme template.

nilsbyte commented 10 years ago

Hey @djcross

  1. Okay if you want to change the source by yourself, you are free to do that :) I am only talking about the official branch.
  2. It's a UI decision. As above, you are free to change that in your own fork.
  3. & 4. I also don't like the slide transitions :-) I was the person who wanted the fades. If you want different transitions for each screen, you can of course change the source by yourself.

Hmm. A override for transitions from a theme element... sounds interesting, in addition to the 'none' option. I will discuss this with @Aloshi. Thanks!

djcross commented 10 years ago

Thanks @nilsbyte