Aloshi / EmulationStation

A flexible emulator front-end supporting keyboardless navigation and custom system themes.
MIT License
2.07k stars 905 forks source link

I created a fork due to inactivity #563

Open Herdinger opened 8 years ago

Herdinger commented 8 years ago

Hey guys, I've only stumbled upon this project recently and it rocks.

Sadly it doesn't cater to all my needs and I was eager to contribute back.

After seeing there is huge backlog of Pull Request I decided to Fork and incorporate all the mayor ones.

Of course nobody likes projects which don't have a canonical source of truth so I am more than willing to put to merge all changes back if EmulationStation gets unfrozen, I just want to move the project forward.

Right now I changed the config directory to something sensible on every platform (.config/emulationstation on linux, Appplication Support or .config/emulationstation on OSX and My Documents on Windows) so you have to move your config there if you want to use the fork.

I've also fixed the build on OSX maybe breaking Linux in the process so it would be nice if someone would check that.

The top of the roadmap is reading all issues and pulls for the next few days

https://github.com/Herdinger/EmulationStation

CWftw commented 8 years ago

Thanks for this. I would love to see this project continue to move forward!

wolf-sigma commented 8 years ago

Hey @Herdinger - I've been thinking of doing the same. I'd hate to fork this, but unless @Aloshi can comment on the status of the project, it might make sense. I'm currently running my own fork on a few platforms (MacOS, Windows, and hopefully soon the RPI). I also looked on RetroPie's fork, and they're trying not to deviate too much from upstream.

I'd be happy to collaborate with you on your fork if you want. I have several opinions on how to make this a better project over all. I've currently pulled in a couple PRs and added support for hiding files in my fork.

Send me an email listed on my profile, and we can chat more if you want.

tynor88 commented 8 years ago

Good job @Herdinger and @t3hi3x , i will start following your fork. This project has definitely been missing some attention. There are alot of good PR's waiting to be merged in :-)

eddywebs commented 8 years ago

Great work guys, I have recently started to work on the repo as weill, I like to contribute however While trying to compile emulationstation on a board called orange pi, its fails at 90% using the below error message. Running an ubuntu arm distribution, and have mali drivers installed. any ideas why ?

make[2]: *** No rule to make target '/usr/lib/arm-linux-gnueabihf/libGL Sv1_CM.so', needed by 'emulationstation'. Stop. CMakeFiles/Makefile2:301: recipe for target 'es-app/CMakeFiles/emulation station.dir/all' failed make[1]: *** [es-app/CMakeFiles/emulationstation.dir/all] Error 2 Makefile:137: recipe for target 'all' failed make: *** [all] Error 2

joeelliott commented 8 years ago

Could you include a -nosplash option for ES, and maybe allow for a color/alpha option for the main screen white bar in the theme? I dont know if I am able to add a feature request to your repository separately, so I just replied to you here :)

Herdinger commented 8 years ago

@joeelliott I've added a --no-splash option (also the boolean SplashScreen int the settings file) since it was a quick fix. I haven't looked at any GUI code yet but I will look into it.

@eddywebs Sorry I have no idea right now. Basically your Makefile expects a library which isn't there. The weird thing is that CMake detects the library and that's the reason it put it in the Makefile in the first place. It would be helpful if you rebuild from the newest commit with "cmake . > logfile.txt" and post the result

slikvik55 commented 8 years ago

Just to check, do we need to compile your fork ourselves?

wolf-sigma commented 8 years ago

@slikvik55 - yeah, at the moment yes. @Herdinger and I are working on some options to download nightly binaries, but the infrastructure isn't setup yet.

heydonovan commented 8 years ago

Any interest in a metadata API strictly for EmulationStation? I'd imagine that it would just return a simple JSON response with release date, publisher, and whatever else people consider important information.

eddywebs commented 8 years ago

Api work is already done by someone > https://github.com/neolao/recalbox-api

It says recalbox but under the hood its all emulationstation, recalbox is just a buildroot unix with emulationstation.

On Wed, Mar 2, 2016 at 5:52 PM, Donovan Hernandez notifications@github.com wrote:

Any interest in a metadata API strictly for EmulationStation? I'd imagine that it would just return a simple JSON response with release date, publisher, and whatever else people consider important information.

— Reply to this email directly or view it on GitHub https://github.com/Aloshi/EmulationStation/issues/563#issuecomment-191479749 .

Best Wishes; Adi

digitalLumberjack commented 8 years ago

@eddywebs feel free to read the doc and the source code before telling that recalbox is just buildroot + ES. Check the api and you will se that none of the rest methods have anything to do with ES.

neolao commented 8 years ago

@eddywebs As indicated by his name, Recalbox API is an API for Recalbox. It doesn't control EmulationStation.

If you look at the documentation, you can modify Recalbox configuration, upload files, create virtual gamepads and launch games.

slikvik55 commented 8 years ago

@heydonovan What sort of uses were you thinking of for the API?

heydonovan commented 8 years ago

@slikvik55 Well, for one I think it's silly to have to resort to scraping of any sort. There should be an API that only returns the information needed. Perhaps support for custom box art (from vgboxart.com).

I'm not too sure what else it would need to do. What does the community want? :p

LatchKeyKid commented 8 years ago

@eddywebs I'm having the same issue as you.https://github.com/Aloshi/EmulationStation/issues/563#issuecomment-187489874 Did you figure out how to fix it? I installed EmulationStation about a month ago on SteamOS without any problems but now I'm on Debian 8. It doesn't make any sense, it should work on Debian, SteamOS is Debian

brando56894 commented 8 years ago

Awesome stuff guys! I'm building a steam machine and would love to use ES as a front-end for all my console games.

I haven't used ES in a way but the major pitfall I remember was having to manually configure each game for each emulator via an XML file. Lets say I have 900 Sega Genesis ROMs, would there be an easy way to batch create XML files for all of them using a pre-configured command string? For Unix-like platforms you could have sed edit the scraped artwork/info XML file and inject in the command string, no idea how you'd do it on Windows though.

wolf-sigma commented 8 years ago

Hi @brando56894

The XML files are auto-generated in these current versions and use a scraper to pull metadata down. You can also confirm which one you want when there is more than one match. You can edit the metadata from ES.

We are planning on pulling in a PR to manage this via sqlite DB (https://github.com/Herdinger/EmulationStation/pull/12), so that might help a bit too.

Does this make sense? Does it address your concerns?

Aloshi commented 8 years ago

Hey, this is a good idea. I was hoping I'd get the motivation to work on EmulationStation again, but I think it's safe to say that hasn't happened, and I should probably give up on waiting for it to happen. Calling ES "dead" sounds bad, so let's just say it's "no longer maintained."

Best of luck...if this is something you're serious about (like "long term maintenance" and "providing binaries" serious), I can put up a link somewhere on the website.

dvelikiy commented 8 years ago

It's great to hear those news! I built my emulation machine in 2015 using EmulationStation as a frontend. I'd love it to get updates and especially better scraping.

ghost commented 8 years ago

interesting i have absolutely no idea what this fork means. but if someone is making new updates to ES, it sure sounds great. is it something that can be downloaded now?..

also Aloshi sad to hear if you wont be working on it anymore, but even so you absolutely destroyed Hyperspin and any other front-end WE LOVE ES

wolf-sigma commented 8 years ago

Hi @Aaskari1988 - yeah, we're making updates to ES on https://github.com/Herdinger/EmulationStation

There aren't any binary downloads yet, but you can download and compile on there.

@Aloshi - THANKS for the support! We definitely are serious, but I'm working on some infrastructure stuff to support that effectively. I'll keep you in the loop on that as we get closer.

Alex

ghost commented 8 years ago

cool. looks to complicated for me, for now. but interesting definitely keeping an eye on it

slikvik55 commented 8 years ago

@Aaskari1988 I may compile a Windows binary this weekend if I get time and will upload it to my site.

I'll post in here if I do.

ghost commented 8 years ago

will it work on my Portable ES ?

ghost commented 8 years ago

any chance we could see new systems added ?

wolf-sigma commented 8 years ago

Sorry for my ignorance, but what is Portable ES? Do you mind linking to some details?

ghost commented 8 years ago

i got from this guy. i never could get the normal install working but this did https://www.youtube.com/watch?v=oHtCnBiyzOY

slikvik55 commented 8 years ago

I also run ES in portable mode - it should be fine. Regarding the Win32 compile, I forgot it's Easter weekend in the UK so I may not get as much time as I hoped!

wolf-sigma commented 8 years ago

Hey folks,

OK, I got buildbot uploading binaries automatically to dropbox. Take a look at https://github.com/Herdinger/EmulationStation 's Readme for a link (incase I change it :) )

All platforms are automatic except Windows...working on writing the batch script for that. I do have the latest binaries (including an install) out there.

zgoda commented 8 years ago

I think the best would be to shift the ownership of this repository to new maintainer.

wolf-sigma commented 8 years ago

Hi @zgoda - definitely open to that (and agree it's better than maintaining a fork), but obviously, that's up to @Aloshi.

OmenBoy commented 8 years ago

Is there any way to give this fork a portable option? I keep my ".emulationstation" folder in ES's program directory and launch it via a batch file containing:

@echo off set HOME=%~dp0 emulationstation.exe

This batch file doesn't work with your fork. Is there any other way for this to be done?

ghost commented 8 years ago

thegamesdb down again. suggestion a different scrapper would be great

wolf-sigma commented 8 years ago

@OmenBoy - I thought about making a parameter for pointing to the config folder to make it easy to do this type of thing. We moved the config folder around. I'd try doing "Documents\EmulationStation" in your ES program folder instead of .emulationstation to see if that works.

OmenBoy commented 8 years ago

@t3hi3x No luck :(

mckaygerhard commented 8 years ago

@OmenBoy the suggestion made by @t3hi3x doesn work never.. guindows does not handle references in bat process due does not hadle it very well..

inlinux either are working due POSIX are follow by OS, and if env variable are imported (eg. import HOME=./usbdrive) will ever work due previously variable set

swicht to linux or try to import a variable, but as i understant "set" its the equivalent of "import" right?

mckaygerhard commented 8 years ago

@Aloshi u can made @t3hi3x and @Herdinger collaborators with write permission ot write pull request on oficial ES repository.. tjhis solves the problem of owership or manteniance of the ES proyect for a while

if u added those guys as collaborators the can work in a brand or by pull request

can we made a brand named "es-comunity" and other "es-official", just like cinellerra (of course not so like) and then comunity can obtain "fan made" releases of the ES proyect.. and the u original author later can track those changes and releases in the oficial brand

another its that those collaborators can continue a more dinamic proyect as comunity-driven of the ES proyect for users only!

OmenBoy commented 8 years ago

Thank you so much for adding the --config-directory command line option! It's working perfect :)

Bulla666 commented 8 years ago

Thanks for all your hard work everyone.

dissolve commented 8 years ago

Are any of the participants still interested in maintaining and/or forking?

mckaygerhard commented 8 years ago

@t3hi3x and @Herdinger had been working, i suggested to made those users collaborators with write permisions, that will solve the problem

dissolve commented 8 years ago

@mckaygerhard that was 3 months ago though and it looks like there hasn't been a commit to @Herdinger 's repo in a month. Thus why I'm bringing it up again. Doesn't look like that is going to happen.

wolf-sigma commented 8 years ago

Definitely still engaged, just slow due to travel and life.

Our main priority is getting unit tests built for the the functionality side of the house. From there, we're looking at features around library management and efficiency.

As always if people want to contribute code, feel free! Especially if you're willing to help build some unit tests.

mckaygerhard commented 8 years ago

well @dissolve we need to former a team and a group in github and a folk official using all the other works and make it a reallity!

but nobody are in pronuncie! i can organize and give to the leqders the passwords, integrate a "faisbuk" and "twitter" accoounds and make it for the .. but i dont see any leader to make it!

i can start tomorrow at the night and in the friday all are ready to commit and post news!

1985a commented 8 years ago

Hello and thanks you for your fork that is still alive this project. I got this problem, while I was compiling the program. img

I'm on Archlinux.

pd: sorry, I'm learning English.

edit:

It appears that libssl no longer contains symbols starting SSLv3. Instead, you should compile [insert whatever it is] against libgnutls-openssl.

I'm talking from the point of view of investigating why curl won't link in that symbol at runtime on debian stable (jessie). Recompiling curl addding a few -lgnutls-openssl into CFLAGS in the Makefiles seems to do the trick.

I have a suspicion how the confusion comes about, but little inclination to interrogate anyone about it!

Now Emulationstation works fine.

mdeguzis commented 7 years ago

Good to hear @Herdinger , i'll track this project for my packages at packages.libregeek.org. Mainly SteamOS, but if anyone wants semi-regular packages for Ubuntu/Debian/Fedora, let me know.