search

Aloshi / EmulationStation

A flexible emulator front-end supporting keyboardless navigation and custom system themes.
MIT License
2.06k stars 905 forks source link

Scraper not working #800

Open Olifiers opened 5 years ago

Olifiers commented 5 years ago

As of 24th of June 2019, none of the two scrapers are returning any matches, nor throwing any error messages when failing to scrap.

ocket8888 commented 5 years ago

TheGamesDB.net now requires registered API keys and the legacy API has been shut down. I'm not sure this project is actually still maintained, but a good place to start would be modifying the request path in GamesDBScraper.cpp

ocket8888 commented 5 years ago

I'm attempting to fix this in #802 , but I think the maintainer of this project may never be around to merge it.

DSMan97 commented 5 years ago

I propose a Solution for this I am goint to use https://api.igdb.com/ API to engace with the Scrapper on the Emulation Station, sorry for my English. I hope that Idea have contributors to develope

ocket8888 commented 5 years ago

they have a 10k/month limit on the free version of their API, and probably have rules against disseminating a paid version to the public

DSMan97 commented 5 years ago

So, what you propose? We can Make It own Api for this but its so much Work.

ocket8888 commented 5 years ago

For now I'm trying to work on giving people a way to configure their own scrapers, but with a default that uses TheGamesDB with my own public API key.

DSMan97 commented 5 years ago

but legacy.thegamesdb.net/api/GetGame.php? is unavailable

ocket8888 commented 5 years ago

sure, but api.thegamesdb.net is available

DSMan97 commented 5 years ago

what?? and works equals, just changeing the String Url and compile Works?

DSMan97 commented 5 years ago

Do you have a working version of emulations station with Scrapper Fix??

ocket8888 commented 5 years ago

Sort of. I have this: #802 which works, assuming you have an API key to put in there. It doesn't have my API key yet, as I'm still testing. It also still includes the other scraper, which I haven't fixed yet.

DSMan97 commented 5 years ago

In Retropie setup fork of EmulationStation is Fixed see here i think, because today I tried and works (I don´t try months before because I thought that is not working) see my gif 2019-07-31004125

Did you fixed ocket8888?

ocket8888 commented 5 years ago

Yes, Retropie seems to have solved this already. Dunno if they've already opened a PR, but it seems unlikely at this point that it'll get merged at any rate.

Mine works, but also is aiming in the long-term to be much more general, and to support any scraper database that matches a certain behavior pattern.

TitanLife commented 5 years ago

Is there a way to search and if multiple results choose between those that return? Kinda similar to hakchi?

Vicj1 commented 4 years ago

What about Windows users? Any way to fix that?

rfrayer420 commented 1 year ago

What about Windows users? Any way to fix that?

I'm just gonna be honest ES is more worried about ARM builds. I understand why and in the big picture it is fair when you consider there isnt anywhere near as many programs for ARM. Doesnt make it suck any less. There are however ES forks that do work great because ES is after all opensource.