Aloxaf / fzf-tab

Replace zsh's default completion selection menu with fzf!
MIT License
3.28k stars 94 forks source link

[BUG] Handle prompt escape sequences #358

Closed kinland closed 7 months ago

kinland commented 1 year ago

Describe the bug

The dev of zsh-autocomplete says that the issue is due to fzf-tab not parsing prompt escape sequences:

@dhorkin No, the problem is that Fzf Tab doesn't know how to parse the prompt escape sequences that are allowed in the completion system's format style. You should file a bug with Fzf Tab about this.

I can make sure:

To Reproduce

Steps to reproduce the behavior:

  1. Type 'git s'
  2. Press Tab
  3. Group legend has %{%} and the like in it

Expected behavior

Prompt escape sequences should be escaped properly and fzf-tab should display the same way regardless of whether zsh-autocomplete is being used

Screenshots

With fzf-tab enabled and zsh-autocomplete disabled: image With both enabled: image

Environment:

Minimal zshrc

If applicable, add a minimal zshrc to help us analyze. .zshrc:

source ${ZDOTDIR:-~}/.antidote/antidote.zsh
antidote load
[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
autoload -Uz compinit && compinit -i

.zsh_plugins.txt

skywind3000/z.lua
changyuheng/fz
marlonrichert/zsh-autocomplete

Log

No log appears when I hit CTRL+X

Aloxaf commented 1 year ago

This is a known issue: https://github.com/Aloxaf/fzf-tab/issues/24

kinland commented 1 year ago

That issue is closed as "completed." If the workaround is those zshrc lines, then that really should be in the readme.