Closed peterldowns closed 2 weeks ago
This pull request fixes the hl+ coloring issues. I can now use any zsh-tinted theme. Excellent! And +1 fzf-tab being superb, utility.
@Aloxaf thank you for merging my contribution, and thank you for creating and maintaining fzf-tab.
Now that this PR is merged, you should probably update the wiki entry for default-color
and close issue #477.
Thanks again 🙇
Done. Thanks for your contribution.
This PR is based on the thread of discussion in https://github.com/Aloxaf/fzf-tab/issues/477. The goal of this PR is to make it so that in order to theme fzf-tab with the same colors as your normal fzf theme, users can use just the following settings in their .zshrc:
As fzf-tab works today, the required settings are:
As a new user of fzf-tab, I am extremely grateful for this project. It works very well and between the fzf knowledge, shell knowledge, and c knowledge required to make it work so quickly, I am seriously impressed by the work that has gone into it. I am hoping that this change will make the user experience better by making it way easier to theme fzf-tab to look like any other fzf instance.
This would be a breaking change. I do not know the history of these default values, but the single-group default color has been [37m since grouping was introduced, although it was originally known as
FZF_TAB_NO_GROUP_COLOR
: https://github.com/Aloxaf/fzf-tab/pull/23/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R121I generally believe that PRs to update default themes/colors should be rejected by maintainers by default, but in this case I'd like you to consider that these changes only make it easier to customize fzf-tab's theme and make it look the way the user wants, by removing defaults present in the project.
I tested this change by using these zshrc settings, and observing that the fzf style matched my default fzf theme as expected, in both light mode and in dark mode:
If this PR is accepted as-is, the wiki entry for
default-color
will also need to be updated.