Closed beppe712 closed 2 years ago
@beppe712 please always refer to the following calendar to add trading holidays. This is the ground truth: https://www.jpx.co.jp/english/corporate/about-jpx/calendar/
We don't care about third party source (e.g. wikipedia)
@beppe712 please always refer to the following calendar to add trading holidays. This is the ground truth: https://www.jpx.co.jp/english/corporate/about-jpx/calendar/
We don't care about third party source (e.g. wikipedia)
The comment was already in the code 😅 They treat equinoxes as ad-hoc holidays so they'd have to be added each year.
tests are missing.
@sercant Done in 94bdc324b0cce3a6daa5c5973da4f2bfdee085cd 😊
@beppe712 you merged this?
@beppe712 you merged this?
Yes I have merged mistakenly into exchange-calendars-head
, and from that branch I am making the PR https://github.com/gerrymanoim/exchange_calendars/pull/135
The 2 missing dates for XTKS for 2022 are the vernal and autumnal equinoxes. Written as a comment in the code: