search

Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
84 stars 29 forks source link

Double jump does not work #102

Closed CoderXL1 closed 6 months ago

CoderXL1 commented 8 months ago

Minecraft Version

1.20.1

Fabric Version

0.15.3

Fabric API Version

0.91.0

Hephaestus Version

3.6.3.240

Describe your issue

The double jump upgrade does not work. Other upgrades like the frost walker are working properly. I am NOT sure if my method of applying double jump is correct. I tried double-clicking the space bar in survival mode but nothing happened. I also tried pressing 'I'(The default key for Leggings Interaction) but still no response.

Crash Report

No response

Other mods

PortingLib 2.1.1163+1.20.1

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues, Checked the FAQ

KonSola5 commented 8 months ago

It's because the info about the extra jumps is stored in a capability, which at this point is null for some reason: https://github.com/Alpha-s-Stuff/TinkersConstruct/blob/8d64ca2073c528d4183dd6add172756c99bcb018/src/main/java/slimeknights/tconstruct/tools/modifiers/ability/armor/DoubleJumpModifier.java#L51-L74

(the PersistentDataCapability.CAPABILITY is null)

KonSola5 commented 8 months ago

debug

AlphaMode commented 6 months ago

Fixed in https://github.com/Alpha-s-Stuff/TinkersConstruct/commit/406cfa581a47288c01b1a1d28aa614f9f54941ed