Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
84 stars 29 forks source link

"Lost X droplets in transfer" logic actually creates fluids out of thin air #117

Open myriapoleis opened 4 months ago

myriapoleis commented 4 months ago

Minecraft Version

1.20.1

Fabric Version

0.15.10

Fabric API Version

0.92.1-1.20.1

Hephaestus Version

3.6.4.273

Describe your issue

When interacting with tanks using buckets, specifically, when inserting a full bucket into a tank with less than 1 bucket of room left, the tank is filled to capacity but the bucket is not emptied. A message is printed to the logs stating "Lost X fluid during transfer", where X is presumably the amount of fluid in droplets that would have been wasted had the bucket been emptied. This insinuates that the intended behavior is to have some material loss when doing this, when in fact the opposite happens. (I personally believe that a small message should pop up saying "cannot insert, not enough room!" or something along those lines, given that there is already a similar message for inserting and withdrawing fluids in other cases. this would keep the fluid in the bucket but not magically produce more)

An easy method of material duplication involves using a fuel tank filled with some resource (ex: molten iron), extracting 8 ingots worth using copper cans, and then refilling it with a bucket of the same resource. The bucket doesnt get emptied, the tank is refilled, and you can repeat the process.

Crash Report

No response

Other mods

None

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched closed issues