Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
84 stars 29 forks source link

Using an empty discrete quantity fluid container (can/bucket) on a seared drain results in material loss #118

Open myriapoleis opened 4 months ago

myriapoleis commented 4 months ago

Minecraft Version

1.20.1

Fabric Version

0.15.10

Fabric API Version

0.92.1-1.20.1

Hephaestus Version

3.6.4.273

Describe your issue

If the player uses an empty fluid container with discrete capacity (can/bucket) on a seared (and or scorched?) drain when there is more fluid of a given material type than could fit in that container, the remaining fluid is removed from the smeltery (and or foundry?) without recompense. This is highly undesirable and makes buckets and cans functionally useless for removing fluid materials from the smeltery, as well as very dangerous.

When this occurs, the console log correctly identifies the amount of fluid lost in the transfer (in droplets). I appreciate that the mod recognizes my suffering, but it hurts that the amount of fluid lost in the transfer is much much more than zero.

Note that if there is not enough fluid present in the smeltery to fill the container being used, the bottom most fluid will be deleted and the container will remain empty. I can see how that might be useful as a method of cleaning up residual fluids (like blood, milk, venom, glass etc). However. The ease by which it occurs unintentionally is distressing. Perhaps a piece of paper could serve that purpose better? (Like a napkin)

The bucketing/melting/spilling ability modifier with tank upgrades is a useful workaround for players to avoid this issue, as no fluids will be lost and nondiscrete amounts can be transferred. Sadly, there is no method of identifying the current fluid or amount stored in a tool without emptying it into a separate holding space. Possible feature suggestion?

Crash Report

No response

Other mods

None

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched closed issues